-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing checksum comparison issue (#396) #406
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
That's a simple, yet great addition! Thank you for this!
One thing I'd suggest though, the choice of color for the text doesn't work great in Light mode.
I'd suggest using an InfoBar, like in Number Base Converter.
You can also use the IsClosable
property of this control to hide the close button at the right (I think it would make sense to not being able to close this information).
Even better, you could make the info bar yellow or red when the hash isn't matching, and green (Severity = Success) when it matches. What do you think about it?
Yeah, sure, I'm fixing that. I am not an experienced UWP developer, I didn't know such control exists, but definitely makes more sense. :) |
- Changes on the comparison evaluator method to support unit testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
Sorry for the late answer. It looks all good now :D Thank you so much for this contribution! Love it !
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Currently, there is no visual indication of the comparison of outputs.
Issue Number: #396
What is the new behavior?
When the Output field and the Output Comparsion field both have value, then a text appears stating "The hashes are the same." or "The hashes are different.", whether the two fields have the same or different values.
Other information
Quality check
Before creating this PR, have you: