Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing checksum comparison issue (#396) #406

Merged
merged 2 commits into from
Feb 21, 2022
Merged

Fixing checksum comparison issue (#396) #406

merged 2 commits into from
Feb 21, 2022

Conversation

astegi-dev
Copy link
Contributor

@astegi-dev astegi-dev commented Feb 17, 2022

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

Currently, there is no visual indication of the comparison of outputs.

Issue Number: #396

What is the new behavior?

When the Output field and the Output Comparsion field both have value, then a text appears stating "The hashes are the same." or "The hashes are different.", whether the two fields have the same or different values.

Other information

Quality check

Before creating this PR, have you:

  • Followed the code style guideline as described in CONTRIBUTING.md
  • Verified that the change work in Release build configuration
  • Checked all unit tests pass

@veler veler linked an issue Feb 18, 2022 that may be closed by this pull request
Copy link
Collaborator

@veler veler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
That's a simple, yet great addition! Thank you for this!

One thing I'd suggest though, the choice of color for the text doesn't work great in Light mode.

image

I'd suggest using an InfoBar, like in Number Base Converter.

image

See here:
https://github.com/veler/DevToys/blob/5e423b37edee81af1e83f6a202d8073036658c8c/src/dev/impl/DevToys/Views/Tools/Converters/NumberBaseConverter/NumberBaseConverterToolPage.xaml#L31-L34

You can also use the IsClosable property of this control to hide the close button at the right (I think it would make sense to not being able to close this information).

Even better, you could make the info bar yellow or red when the hash isn't matching, and green (Severity = Success) when it matches. What do you think about it?

@astegi-dev
Copy link
Contributor Author

Yeah, sure, I'm fixing that.

I am not an experienced UWP developer, I didn't know such control exists, but definitely makes more sense. :)

@astegi-dev
Copy link
Contributor Author

Screenshots of the modification:
When hashes match:
image

When hashes does not match:
image

On light background:
image
image

- Changes on the comparison evaluator method to support unit testing
Copy link
Collaborator

@veler veler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
Sorry for the late answer. It looks all good now :D Thank you so much for this contribution! Love it !

@veler veler merged commit d5c9e4d into DevToys-app:main Feb 21, 2022
veler pushed a commit that referenced this pull request Mar 31, 2023
* Fixing checksum comparison issue (#396)

* - Fixing warning message
- Changes on the comparison evaluator method to support unit testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checksum Generator won't do comparison
2 participants